Fix a few problems found running "pod spec lint". #213
Conversation
This includes updating the minimum supported iOS and OSX versions to match gRPC and a fix for a compiler warning found by the linter. The compiler warning was due to careless conversion of grpc event tags from void * to various integer types that were 64 bit but inappropriate for 32 bit architectures. The change now directly exposes void * tags from the shim layer and converts them from UnsafeMutableRawPointers to Int (and back) in SwiftGRPC/Core.
|
@MrMage @rebello95 PTAL. I'm hoping that this podspec is ready to go to the CocoaPods Master Repo. |
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
🎉 awesome! Thank you for doing this.
| type = CompletionType.completionType(event.type) | ||
| success = event.success | ||
| tag = cgrpc_event_tag(event) | ||
| tag = Int(bitPattern:cgrpc_event_tag(event)) |
There was a problem hiding this comment.
nit: Looks like elsewhere in the codebase there's normally a space between the : and the argument - i.e., Int(bitPattern: cgrpc_event_tag(event)). Same below in Handler.swift 🤷♂️
There was a problem hiding this comment.
thanks for catching this
SwiftGRPC.podspec
Outdated
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = 'SwiftGRPC' | ||
| s.version = '0.4.1' |
There was a problem hiding this comment.
Should we bump this to 0.4.2?
SwiftGRPC.podspec
Outdated
| } | ||
|
|
||
| s.summary = 'Swift gRPC code generator plugin and runtime library' | ||
| s.homepage = 'http://www.grpc.io' |
There was a problem hiding this comment.
Might want to update this to https
|
FYI I also have a PR from a few weeks ago open against gRPC Core to fix some |
MrMage
left a comment
MrMage
left a comment
There was a problem hiding this comment.
LGTM save for the things pointed out by @rebello95.
FYI, I've also encountered some build warning with the gRPC CocoaPod (both before and since using gRPC v1.11):
I think they are related because the script that builds the gRPC Podspec from a template duplicates some file paths in the Podspec's path fields. I don't have the time to investigate fixing that right now, though ;-)
|
@rebello95 Thanks for creating grpc/grpc#14854! |
This includes updating the minimum supported iOS and OSX versions
to match gRPC and a fix for a compiler warning found by the linter.
The compiler warning was due to careless conversion of grpc event tags
from void * to various integer types that were 64 bit but inappropriate
for 32 bit architectures. The change now directly exposes void * tags
from the shim layer and converts them from UnsafeMutableRawPointers
to Int (and back) in SwiftGRPC/Core.